-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvirt: support aarch64 arch VM #2037
libvirt: support aarch64 arch VM #2037
Conversation
25fb8b0
to
4ef2177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, but otherwise this looks good. Thanks!
4ef2177
to
33874c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @xutao323!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @xutao323
33874c2
to
11bc8bc
Compare
Get correct yq package name and specify virt machine type for aarch64. Signed-off-by: Tao Xu <[email protected]> Reviewed-by: Seunguk Shin <[email protected]> Reviewed-by: Nick Connolly <[email protected]>
11bc8bc
to
acd5bf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and the tests are passing now. Thanks for the updates!
Get correct yq package name and specify virt machine type for aarch64 instead of relying on kcli (karmab/kcli@7cad52c won't override the machine type from user's input for aarch64 any more).
Also sent some minor
kcli
changes here: karmab/kcli#718With above changes,
kcli_cluster.sh create
can successfully create k8s cluster on aarch64.