Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt: support aarch64 arch VM #2037

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

xutao323
Copy link
Contributor

Get correct yq package name and specify virt machine type for aarch64 instead of relying on kcli (karmab/kcli@7cad52c won't override the machine type from user's input for aarch64 any more).

Also sent some minor kcli changes here: karmab/kcli#718

With above changes, kcli_cluster.sh create can successfully create k8s cluster on aarch64.

$ ./libvirt/kcli_cluster.sh create
...
$ export KUBECONFIG=~/.kcli/clusters/peer-pods/auth/kubeconfig 
$ kubectl get nodes
NAME                   STATUS   ROLES           AGE    VERSION
peer-pods-ctlplane-0   Ready    control-plane   3m6s   v1.30.0
peer-pods-worker-0     Ready    worker          92s    v1.30.0
$ kubectl get pods -A
NAMESPACE       NAME                                           READY   STATUS      RESTARTS   AGE
autorules       autoruler-5ff4dbbf7-fqtz7                      1/1     Running     0          2m51s
ingress-nginx   ingress-nginx-admission-create-kjq68           0/1     Completed   0          2m51s
ingress-nginx   ingress-nginx-admission-patch-thzcq            0/1     Completed   1          2m51s
ingress-nginx   ingress-nginx-controller-54cf9c8856-nzxww      1/1     Running     0          2m51s
kube-flannel    kube-flannel-ds-shvsz                          1/1     Running     0          95s
kube-flannel    kube-flannel-ds-szhwj                          1/1     Running     0          2m51s
kube-system     coredns-7db6d8ff4d-b4pjx                       1/1     Running     0          2m51s
kube-system     coredns-7db6d8ff4d-j7dxt                       1/1     Running     0          2m51s
kube-system     etcd-peer-pods-ctlplane-0                      1/1     Running     0          3m7s
kube-system     kube-apiserver-peer-pods-ctlplane-0            1/1     Running     0          3m5s
kube-system     kube-controller-manager-peer-pods-ctlplane-0   1/1     Running     0          3m5s
kube-system     kube-multus-ds-qf2g7                           1/1     Running     0          95s
kube-system     kube-multus-ds-t6dww                           1/1     Running     0          2m51s
kube-system     kube-proxy-mm2gk                               1/1     Running     0          2m51s
kube-system     kube-proxy-pnwdr                               1/1     Running     0          95s
kube-system     kube-scheduler-peer-pods-ctlplane-0            1/1     Running     0          3m5s

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, but otherwise this looks good. Thanks!

src/cloud-api-adaptor/libvirt/kcli_cluster.sh Outdated Show resolved Hide resolved
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @xutao323!

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @xutao323

@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Sep 13, 2024
Get correct yq package name and specify virt machine type for aarch64.

Signed-off-by: Tao Xu <[email protected]>
Reviewed-by: Seunguk Shin <[email protected]>
Reviewed-by: Nick Connolly <[email protected]>
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the tests are passing now. Thanks for the updates!

@stevenhorsman stevenhorsman merged commit 5f93228 into confidential-containers:main Sep 13, 2024
28 checks passed
@xutao323 xutao323 deleted the arm64_support branch September 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants