Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cloud-api-adaptor logging enhancements #2011

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Aug 15, 2024

Minor, almost trivial, logging enhancements

@EmmEff EmmEff marked this pull request as draft August 15, 2024 20:55
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

EmmEff added 6 commits August 16, 2024 14:10
Ran gofmt against src/cloud-api-adaptor/pkg/adaptor/cloud/cloud.go

Signed-off-by: Mike Frisch <[email protected]>
Minor fixups- error wrapping, use of Print() instead of Printf(), etc.

Signed-off-by: Mike Frisch <[email protected]>
Remove extraneous linefeed from log message

Signed-off-by: Mike Frisch <[email protected]>
As above. String has no args so just output verbatim

Signed-off-by: Mike Frisch <[email protected]>
Do not leave the user wondering why the StartVM operation shutdown the proxy

Signed-off-by: Mike Frisch <[email protected]>
Log progress for agent proxy connection

Signed-off-by: Mike Frisch <[email protected]>
@EmmEff EmmEff force-pushed the logging-enhancements branch from f07f00b to 7ad7c09 Compare August 16, 2024 18:30
@EmmEff EmmEff marked this pull request as ready for review August 16, 2024 18:32
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @EmmEff

@bpradipt bpradipt merged commit 3c2c82e into confidential-containers:main Aug 20, 2024
20 checks passed
@EmmEff EmmEff deleted the logging-enhancements branch August 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants