-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor cloud-api-adaptor logging enhancements #2011
Minor cloud-api-adaptor logging enhancements #2011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Ran gofmt against src/cloud-api-adaptor/pkg/adaptor/cloud/cloud.go Signed-off-by: Mike Frisch <[email protected]>
Minor fixups- error wrapping, use of Print() instead of Printf(), etc. Signed-off-by: Mike Frisch <[email protected]>
Remove extraneous linefeed from log message Signed-off-by: Mike Frisch <[email protected]>
As above. String has no args so just output verbatim Signed-off-by: Mike Frisch <[email protected]>
Do not leave the user wondering why the StartVM operation shutdown the proxy Signed-off-by: Mike Frisch <[email protected]>
Log progress for agent proxy connection Signed-off-by: Mike Frisch <[email protected]>
f07f00b
to
7ad7c09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @EmmEff
Minor, almost trivial, logging enhancements