Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set proxy dialer timeout #2007

Merged

Conversation

EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Aug 15, 2024

Use proxy timeout value to set dialer timeout. Default for TCP connections is documented as ~3 minutes, which has proven to be insufficient on AWS.

The proxy timeout value is set through peer-pods-cm ConfigMap as PROXY_TIMEOUT.

EmmEff added 2 commits August 15, 2024 10:47
Ran 'gofmt' against proxy.go

Signed-off-by: Mike Frisch <[email protected]>
Override system default TCP dialer timeout (~3 minutes) with proxy timeout.

Signed-off-by: Mike Frisch <[email protected]>
@EmmEff EmmEff mentioned this pull request Aug 15, 2024
Copy link
Member

@yoheiueda yoheiueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bpradipt bpradipt merged commit c154796 into confidential-containers:main Aug 20, 2024
20 checks passed
@EmmEff EmmEff deleted the set-proxy-dialer-timeout branch August 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants