forwarder: remove aa_kbc_params from daemon.jsom #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
requested review from
bpradipt,
kartikjoshi21,
huoqifeng and
stevenhorsman
|
Looks an error in: |
This field is not used by the forwarder component or anywhere else, aa-kbc-params is managed as part of AA and CDH, having this field duplicated in daemon.json could produce confusion. Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/remove-aakbcparams-from-daemon-json
branch
from
ba21e40 to
eb304a0
Compare
|
nit: s/daemon.jsom/daemon.json in the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is not used by the forwarder component or anywhere else, aa-kbc-params is managed as part of AA and CDH, having this field duplicated in daemon.json could produce confusion.