Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1879: fix LegacyKeyValueFormat warnings when build docker images #1880

Merged

Conversation

liudalibj
Copy link
Member

  • LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format

fixes #1879

- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format

fixes confidential-containers#1879

Signed-off-by: Da Li Liu <[email protected]>
@liudalibj liudalibj requested review from bpradipt, mkulke, huoqifeng and stevenhorsman and removed request for bpradipt June 24, 2024 13:56
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @liudalibj!

Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @liudalibj

@huoqifeng huoqifeng merged commit 33c3053 into confidential-containers:main Jun 24, 2024
18 checks passed
@liudalibj liudalibj deleted the fix-LegacyKeyValueFormat branch June 25, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LegacyKeyValueFormat warnings are found in dev machine and CI logs.
3 participants