Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e: update assessment_runner.go #1808

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

chathuryaadapa
Copy link
Contributor

updating the code to check caa logs for podfail reason instead of podstatus

fixes: #1807

@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Apr 17, 2024
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - I've left a couple of minor comments and once resolved can you squash the commits together please. Thanks

src/cloud-api-adaptor/test/e2e/assessment_runner.go Outdated Show resolved Hide resolved
src/cloud-api-adaptor/test/e2e/assessment_runner.go Outdated Show resolved Hide resolved
updating the code to check caa logs for podfail reason instead of podstatus

Signed-off-by: Adapa Chathurya <[email protected]>
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @chathuryaadapa

@stevenhorsman stevenhorsman merged commit 01a9ffa into confidential-containers:main Apr 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating PodFail scenario check
3 participants