Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin packer plugins versions #1759

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

snir911
Copy link
Contributor

@snir911 snir911 commented Mar 25, 2024

Reasons:

  • avoid unexpected bugs (there's one in latest azure plugin)
  • avoid license changes
  • packer usage for podvm creation is expected to be deprecated soon

@snir911 snir911 requested review from surajssd and bpradipt March 25, 2024 09:03
@snir911 snir911 self-assigned this Mar 25, 2024
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @snir911 those lgtm.

Do you mind just copying the PR description into the git log message? So we can easily understand why we are pinning by just looking at the git messages?

snir911 added 2 commits March 26, 2024 10:13
to version 1.3.1,
reasons:
- avoid unexpected bugs
- avoid license changes
- packer usage for podvm creation is expected to be deprecated soon

Signed-off-by: Snir Sheriber <[email protected]>
to version 2.0.2
reasons:
- avoid unexpected bugs (there's one in current version)
- avoid license changes
- packer usage for podvm creation is expected to be deprecated soon

Signed-off-by: Snir Sheriber <[email protected]>
@snir911 snir911 force-pushed the az_pkr_pin_versions branch from 2500f6b to 1b77e9f Compare March 26, 2024 08:15
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng huoqifeng merged commit d02deab into confidential-containers:main Apr 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants