-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kbs: pin down to released working kbs image version #1689
kbs: pin down to released working kbs image version #1689
Conversation
5f04a8b
to
c5d17f3
Compare
versions.yaml
Outdated
image: | ||
kbs: | ||
registry: ghcr.io/confidential-containers/key-broker-service | ||
tag: 7ec54fa8f74b9bf24d84ef4a35d050d068105732 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tag probably does not exists:
coco-tenant 0s Warning Failed pod/kbs-5864d9656d-r25nk Failed to pull image "ghcr.io/confidential-containers/key-broker-service:7ec54fa8f74b9bf24d84ef4a35d050d068105732": rpc error: code = NotFound desc = failed to pull and unpack image "ghcr.io/confidential-containers/key-broker-service:7ec54fa8f74b9bf24d84ef4a35d050d068105732": failed to resolve reference "ghcr.io/confidential-containers/key-broker-service:7ec54fa8f74b9bf24d84ef4a35d050d068105732": ghcr.io/confidential-containers/key-broker-service:7ec54fa8f74b9bf24d84ef4a35d050d068105732: not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct registry is ghcr.io/confidential-containers/staged-images/kbs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to deploy ghcr.io/confidential-containers/staged-images/kbs:7ec54fa8f74b9bf24d84ef4a35d050d068105732
but it has the same problem as using the current main
.
✗ kubectl logs -n coco-tenant kbs-85446fdff5-grpzj
[2024-02-07T22:03:13Z INFO kbs] Using config file /etc/kbs/kbs-config.toml
Error: invalid config: missing field `rvps_config`
It seems like we don't have any pre-built image which has this problem solved. I even tried the first ever built image and it too has same problem: c3ab7bbdc458362d971062b087ed68d4998dacad. |
@kartikjoshi21 PTAL confidential-containers/trustee#318 latest image should work with this config change. |
eb87781
to
0ed80af
Compare
I have pointed out to latest released image tag for now and it can bring the pod up atleast. We need to push image with tag |
0ed80af
to
0a01f88
Compare
note: there was a kbs 0.8.2 release tagged recently, maybe that's what could be used? https://github.com/confidential-containers/kbs/tree/v0.8.2 |
0a01f88
to
94959de
Compare
@mkulke i think with this PR we can point out to latest kbs tag in this repo |
Do you mean a hash of the current main? or a "latest" tag? 0.8.2 is pretty close to the kbs' HEAD and there is no explicit version coupling to guest-components (there won't be a 0.8.2 release) |
94959de
to
b14006f
Compare
I m currently using this tag |
Sure, that would work as well. |
b14006f
to
f1f47ac
Compare
Fix: confidential-containers#1688 Signed-off-by: Kartik Joshi <[email protected]>
f1f47ac
to
56ce4a8
Compare
Fix: #1688