Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbs: pin down to released working kbs image version #1689

Conversation

kartikjoshi21
Copy link
Contributor

Fix: #1688

versions.yaml Outdated Show resolved Hide resolved
@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/kbs-image-version branch from 5f04a8b to c5d17f3 Compare February 6, 2024 07:31
versions.yaml Outdated
image:
kbs:
registry: ghcr.io/confidential-containers/key-broker-service
tag: 7ec54fa8f74b9bf24d84ef4a35d050d068105732
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag probably does not exists:

coco-tenant 0s Warning Failed pod/kbs-5864d9656d-r25nk Failed to pull image "ghcr.io/confidential-containers/key-broker-service:7ec54fa8f74b9bf24d84ef4a35d050d068105732": rpc error: code = NotFound desc = failed to pull and unpack image "ghcr.io/confidential-containers/key-broker-service:7ec54fa8f74b9bf24d84ef4a35d050d068105732": failed to resolve reference "ghcr.io/confidential-containers/key-broker-service:7ec54fa8f74b9bf24d84ef4a35d050d068105732": ghcr.io/confidential-containers/key-broker-service:7ec54fa8f74b9bf24d84ef4a35d050d068105732: not found

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct registry is ghcr.io/confidential-containers/staged-images/kbs.

Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to deploy ghcr.io/confidential-containers/staged-images/kbs:7ec54fa8f74b9bf24d84ef4a35d050d068105732 but it has the same problem as using the current main.

✗ kubectl logs -n coco-tenant kbs-85446fdff5-grpzj
[2024-02-07T22:03:13Z INFO  kbs] Using config file /etc/kbs/kbs-config.toml
Error: invalid config: missing field `rvps_config`

@surajssd
Copy link
Member

surajssd commented Feb 7, 2024

It seems like we don't have any pre-built image which has this problem solved. I even tried the first ever built image and it too has same problem: c3ab7bbdc458362d971062b087ed68d4998dacad.

@surajssd
Copy link
Member

surajssd commented Feb 7, 2024

@kartikjoshi21 PTAL confidential-containers/trustee#318 latest image should work with this config change.

@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/kbs-image-version branch 2 times, most recently from eb87781 to 0ed80af Compare February 12, 2024 08:24
@kartikjoshi21
Copy link
Contributor Author

@kartikjoshi21 PTAL confidential-containers/kbs#318 latest image should work with this config change.

I have pointed out to latest released image tag for now and it can bring the pod up atleast. We need to push image with tag 7ec54fa8f74b9bf24d84ef4a35d050d068105732 and latest rvps config change to staged images repo for all the things to work as this commit is compatible with guest-component and kbs but i dont have permission for the same.

@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/kbs-image-version branch from 0ed80af to 0a01f88 Compare February 13, 2024 06:58
@mkulke
Copy link
Collaborator

mkulke commented Feb 13, 2024

note: there was a kbs 0.8.2 release tagged recently, maybe that's what could be used? https://github.com/confidential-containers/kbs/tree/v0.8.2

@kartikjoshi21
Copy link
Contributor Author

note: there was a kbs 0.8.2 release tagged recently, maybe that's what could be used? https://github.com/confidential-containers/kbs/tree/v0.8.2

@mkulke i think with this PR we can point out to latest kbs tag in this repo

@mkulke
Copy link
Collaborator

mkulke commented Feb 20, 2024

note: there was a kbs 0.8.2 release tagged recently, maybe that's what could be used? https://github.com/confidential-containers/kbs/tree/v0.8.2

@mkulke i think with this PR we can point out to latest kbs tag in this repo

Do you mean a hash of the current main? or a "latest" tag? 0.8.2 is pretty close to the kbs' HEAD and there is no explicit version coupling to guest-components (there won't be a 0.8.2 release)

@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/kbs-image-version branch from 94959de to b14006f Compare February 20, 2024 10:32
@kartikjoshi21
Copy link
Contributor Author

note: there was a kbs 0.8.2 release tagged recently, maybe that's what could be used? https://github.com/confidential-containers/kbs/tree/v0.8.2

@mkulke i think with this PR we can point out to latest kbs tag in this repo

Do you mean a hash of the current main? or a "latest" tag? 0.8.2 is pretty close to the kbs' HEAD and there is no explicit version coupling to guest-components (there won't be a 0.8.2 release)

I m currently using this tag 6a9be1cd9d1522d6892c36cb80c415af1078b1e2 for kbs repo. But i think using kbs 0.8.2 make sense as well. @surajssd wdyt ?

@surajssd
Copy link
Member

I m currently using this tag 6a9be1cd9d1522d6892c36cb80c415af1078b1e2 for kbs repo. But i think using kbs 0.8.2 make sense as well. @surajssd wdyt ?

Sure, that would work as well.

@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/kbs-image-version branch from b14006f to f1f47ac Compare February 21, 2024 07:19
versions.yaml Outdated Show resolved Hide resolved
@kartikjoshi21 kartikjoshi21 requested a review from mkulke February 21, 2024 19:42
@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/kbs-image-version branch from f1f47ac to 56ce4a8 Compare February 27, 2024 16:05
@surajssd surajssd merged commit 2ab1beb into confidential-containers:main Feb 27, 2024
18 checks passed
@kartikjoshi21 kartikjoshi21 deleted the kartikjoshi21/kbs-image-version branch February 28, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin down to kbs image version in versions.yaml
3 participants