-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically fetch config map values #1199
Conversation
84c3bda
to
6657690
Compare
@snir911 @bpradipt the solution to the issues mentioned in the PR description are:
|
90cf934
to
b541470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! i added some comments, also please look at the build and lint actions
e8c535b
to
b7e5a8a
Compare
Updated to work only on Azure. Managed services like ARO and AKS are left as TODO, since they have different resource groups and the Azure SDK API might not fully support them yet. |
@esposem can you please rebase this PR ? |
It is used nowhere. Fixes: confidential-containers#1200 Signed-off-by: Emanuele Giuseppe Esposito <[email protected]>
Using the Azure SDK, we don't need to provide AZURE_IMAGE_ID, AZURE_SUBNET_ID and AZURE_NSG_ID to the ConfigMap. If each query returns more than a result, return an error and let the user specify the actual value needed in the ConfigMap. Fixes: confidential-containers#1200 Signed-off-by: Emanuele Giuseppe Esposito <[email protected]>
This PR gets rid of some ConfigMap parameters that must be provided to CAA in order to make it run on Azure/AWS.
More specifically:
and becomes now
Current limitations of this patch
azure:
Fixes: #1200