Skip to content

Commit

Permalink
test-e2e: Add check for validating kbs image and kbs image tag
Browse files Browse the repository at this point in the history
Validate kbs image and kbs image tag only when deploy kbs is
enabled.

Signed-off-by: Kartik Joshi <[email protected]>
  • Loading branch information
kartikjoshi21 authored and mkulke committed Mar 6, 2024
1 parent 059bff6 commit 887b892
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 5 additions & 2 deletions test/e2e/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,12 @@ func TestMain(m *testing.M) {
var err error

// Get properties

props := provisioner.GetProperties(ctx, cfg)
if props["KBS_IMAGE"] == "" || props["KBS_IMAGE_TAG"] == "" {
return ctx, fmt.Errorf("kbs image not provided")
if shouldDeployKbs {
if props["KBS_IMAGE"] == "" || props["KBS_IMAGE_TAG"] == "" {
return ctx, fmt.Errorf("kbs image not provided")
}
}

if shouldProvisionCluster {
Expand Down
1 change: 0 additions & 1 deletion test/provisioner/azure/provision_azure.properties
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ IS_SELF_MANAGED_CLUSTER="false"
# KBS configs
KBS_IMAGE="${KBS_IMAGE}"
KBS_IMAGE_TAG="${KBS_IMAGE_TAG}"
DEPLOY_KBS="true"

0 comments on commit 887b892

Please sign in to comment.