Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support basic auth for API gateways #75

Merged

Conversation

gbecan
Copy link
Collaborator

@gbecan gbecan commented Dec 5, 2024

New environment variables to support Basic auth. This is needed when an API gateway sits between the CLI and Console.
It allows to pass client id and secret to the gateway which in turn will send a JWT token to Console.

Tested with Kong openid-connect plugin + Keycloak

client/console_client.go Outdated Show resolved Hide resolved
Copy link
Member

@qboileau qboileau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but need some doc on README.
@marnas WDYT ? It's something we might support on terraform provider too at some point.

@marnas
Copy link
Contributor

marnas commented Dec 6, 2024

I think it would be great if we could add some input validation on CDK_AUTH_MODE also to define what are the possible values and letting the user know of any misconfiguration, since at the moment we're only checking whether the value is external and taking everything else still as good.

A part from that it looks good to me and we'll definitely want to add something similar to the TF provider. Great feature!

@sderosiaux sderosiaux changed the title Add CDK_EXTERNAL_USER/CDK_EXTERNAL_PASSWORD to support basic auth for API gateways Support basic auth for API gateways Dec 6, 2024
README.md Show resolved Hide resolved
@gbecan gbecan merged commit 9f232e2 into main Dec 6, 2024
4 checks passed
@gbecan gbecan deleted the cons-2210-adapt-cli-to-be-able-to-pass-creds-for-external-jwt branch December 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants