Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -k #12

Merged
merged 3 commits into from
Feb 28, 2024
Merged

add -k #12

merged 3 commits into from
Feb 28, 2024

Conversation

strokyl
Copy link
Collaborator

@strokyl strokyl commented Feb 28, 2024

No description provided.

@strokyl strokyl marked this pull request as ready for review February 28, 2024 13:30
Copy link
Member

@qboileau qboileau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why -k for directory ? in kubectl the -k is for a directory yes but of kustomize resources not simple manifest. and kubectl (or bash not sure) support glob pattern in -f file like '*.yml' to take all .yml files in current directory and it should work with other directory as well like ./manifests/*.yml

IMO we should not have a new flags for directories or if we really need it because we can't implement glob pattern filter then something like -d is better than a -k

@strokyl
Copy link
Collaborator Author

strokyl commented Feb 28, 2024

why -k for directory ? in kubectl the -k is for a directory yes but of kustomize resources not simple manifest. and kubectl (or bash not sure) support glob pattern in -f file like '*.yml' to take all .yml files in current directory and it should work with other directory as well like ./manifests/*.yml

IMO we should not have a new flags for directories or if we really need it because we can't implement glob pattern filter then something like -d is better than a -k

Julien what do you think?

@twobeeb
Copy link
Contributor

twobeeb commented Feb 28, 2024

Yes my bad,
Following kubectl logic:
-f should take a file or folder, and take all manifests (.yaml or .yml) from the folder.
-R to recurse into subfolders (later)

cmd/apply.go Outdated Show resolved Hide resolved
Co-authored-by: Quentin <[email protected]>
@strokyl strokyl merged commit 62dac70 into main Feb 28, 2024
4 checks passed
@qboileau qboileau deleted the add_-k branch March 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants