WIP: url with trailing slash mirror #943
Open
+1,085
−525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose adding another crate lije url-utils or whatever would help? We could also rename file_url and add it there? |
|
Do you think file-url and urlwithslash could be in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@baszalmstra I refactored things to use the URLWithSlash in the mirror.
Unfortunately, that type currently lives in
rattler_conda_types. I need it inrattler_networkingthough. They both currently don't have a relationship.We could add another utils crate or make one dependent on the other. Not sure. Happy about suggestions.
This PR builds on top of #939 and I'd suggest merging that one first.