Set AppUserModelId on Windows shortcuts
#133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
@mrclary - this looks like it's working. Before I create some dev packages for us to try on installers, can you take a look a this PR and let me know if there's anything off? Thanks! |
|
@jaimergp, I cannot comment on the C++ code, but everything else looks good to me. I probably won't get a chance to test the branch until tomorrow, but I don't think you need wait on me. |
15 tasks
Czaki
pushed a commit
to napari/napari
that referenced
this pull request
Jul 28, 2023
…to bundle shortcut) (#6056) # Fixes/Closes Needed to consolidate changes in napari/packaging#77. This culminates the fix for napari/packaging#69, hopefully 🤞 # Description This adds the metadata necessary to set an [AppUserModelId](https://learn.microsoft.com/en-us/windows/win32/properties/props-system-appusermodel-id) on the Windows shortcut, which helps Windows handle things like grouping taskbar icons and windows. # References * https://learn.microsoft.com/en-us/windows/win32/properties/props-system-appusermodel-id * conda/menuinst#133 * conda/menuinst#127 * spyder-ide/spyder#20791 (comment)
Czaki
pushed a commit
to napari/napari
that referenced
this pull request
Oct 17, 2023
…to bundle shortcut) (#6056) # Fixes/Closes Needed to consolidate changes in napari/packaging#77. This culminates the fix for napari/packaging#69, hopefully 🤞 # Description This adds the metadata necessary to set an [AppUserModelId](https://learn.microsoft.com/en-us/windows/win32/properties/props-system-appusermodel-id) on the Windows shortcut, which helps Windows handle things like grouping taskbar icons and windows. # References * https://learn.microsoft.com/en-us/windows/win32/properties/props-system-appusermodel-id * conda/menuinst#133 * conda/menuinst#127 * spyder-ide/spyder#20791 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will close #127
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?