Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: conda_interface should be able to handle alpha, beta, rc versions #496

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

jaimergp
Copy link
Contributor

The previous approach will fail with non-final conda versions (e.g. 4.12a1). This uses conda.models.VersionOrder instead, which has been stable since 2016, so I'd say it's safe to use.

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 10, 2022
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion around accessing version specifiers with a bit more defensive programming.

constructor/conda_interface.py Outdated Show resolved Hide resolved
@jezdez jezdez merged commit 2b66657 into conda:master Mar 11, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants