Fixes to the new solver & VersionOrder #2036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes motivated by several issues reported by testers: #2033, #1912, #1476, #1334, etc.
The key problem with regards to features was that the pruning pass was eliminating features from consideration prematurely. We've moved the elimination pass until after the first scan to make sure to catch all of the
track_features
entries that would be caught by the specs.I've also adjusted the optimization passes so that they proceed in the following order:
track_feature
s selected to achieve 'conda update anaconda' should fail when no internet is available #1. This won't touchtrack_feature
s that are embedded in installed metapackages or packages likepython
that always have them. But it will ensure that no additional, unnecessarytrack_feature
values are added to the mix.If anyone is nerdy enough (like me) to parse this and consider its consequences, please do, and let me know if you have any concerns.