Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate compatibility with libmamba 1.5.0 #266

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Aug 24, 2023

Description

One test broke with libmamba 1.5.0: test_solvers.py::test_defaults_specs_work. libmamba is not able to handle defaults::* as a matchspec, but in <=1.4.9 we could workaround by translating defaults to the most likely pkgs/* equivalent. This workaround doesn't work in 1.5.0 anymore so I am simply xfailing the test and adding a cleaner exception to the UI.

This is reported upstream at mamba-org/mamba#2431, but no solution is available yet.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 24, 2023
@jaimergp jaimergp marked this pull request as ready for review August 25, 2023 15:13
@jaimergp
Copy link
Contributor Author

Errors are unrelated (see #267 and #242). This doesn't fix the underlying issue but does annotate the offending test as xfail. Work is needed upstream for a proper fix.

@jaimergp jaimergp requested review from jezdez and costrouc August 25, 2023 15:55
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor nit

conda_libmamba_solver/solver.py Outdated Show resolved Hide resolved
@jaimergp jaimergp merged commit 957b221 into main Aug 29, 2023
@jaimergp jaimergp added this to the September 2023 release milestone Sep 25, 2023
@jaimergp jaimergp deleted the investigate-libmamba-150 branch November 7, 2023 10:24
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants