-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compatibility with cryptography>=41. #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Jun 1, 2023
kenodegard
reviewed
Jun 2, 2023
jezdez
changed the title
Remove private class
Reimplement private and public key classes following breakage from upstream API change
Jun 2, 2023
kenodegard
reviewed
Jun 6, 2023
ping? |
kenodegard
previously approved these changes
Aug 17, 2023
@jezdez news? |
kenodegard
reviewed
Aug 17, 2023
kenodegard
approved these changes
Aug 17, 2023
jezdez
changed the title
Reimplement private and public key classes following breakage from upstream API change
Improve compatibility with cryptography>=41.
Aug 17, 2023
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
[bot] added once the contributor has signed the CLA
locked
[bot] locked due to inactivity
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #56 by stop using a hack to override the subclass of the private and public key classes after it stopped working when cryptography switched to a Rust implementation in pyca/cryptography#8697.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?