-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: init loggers once #5383
perf: init loggers once #5383
Conversation
@conda/builds-tools This PR is ready for review! Note that the python 3.12 failures are due to a deprecation warning for python 3.14 that comes out of code in conda-package-handling. |
How much do we understand about the original behavior, besides that conad-build does strange things to logging (store all messages and suppress duplicates?) as a side effect of importing its logging utility? There was a comment about the user being able to override settings? |
I understand nothing and yes user overrides are really hard. FWIW, the current code base has a mix of making the loggers once at the top of each module versus making them on-the-fly. This PR simply changes all of the loggers to be made at the top of each module. So apparently the loggers do work when imported at the top. I'd like to defer cleaning up and/or changing the logging usage to another PR. |
CodSpeed Performance ReportMerging #5383 will not alter performanceComparing Summary
|
I am closing this in favor of a smaller fix in #5384. |
Description
This PR initializes the loggers once at the top of each module to hopefully reduce overheads.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?closes #5382