Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pickle's loads/dumps as a faster deepcopy #5281

Merged
merged 22 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions conda_build/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import copy
import math
import os
import pickle
import re
import shutil
import time
Expand Down Expand Up @@ -820,9 +821,12 @@ def clean_pkgs(self):

def copy(self) -> Config:
new = copy.copy(self)
new.variant = copy.deepcopy(self.variant)
# Use picke.loads(pickle.dumps(...) as a faster copy.deepcopy alternative.
new.variant = pickle.loads(pickle.dumps(self.variant, pickle.HIGHEST_PROTOCOL))
if hasattr(self, "variants"):
new.variants = copy.deepcopy(self.variants)
new.variants = pickle.loads(
pickle.dumps(self.variants, pickle.HIGHEST_PROTOCOL)
)
return new

# context management - automatic cleanup if self.dirty or self.keep_old_work is not True
Expand Down
3 changes: 3 additions & 0 deletions news/5281-perf-deepcopy
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Enhancements

* Increased performance by using pickle instead of deepcopy. (#5281)
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ filterwarnings = [
# ignore conda-index error
"ignore::PendingDeprecationWarning:conda_index",
"ignore::DeprecationWarning:conda_index",
'ignore:\s+Python:DeprecationWarning',
beckermr marked this conversation as resolved.
Show resolved Hide resolved
]
markers = [
"serial: execute test serially (to avoid race conditions)",
Expand Down
Loading