Deprecate conda_build.utils.samefile in favor of path to package mapping
#5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kenodegard
commented
Jan 2, 2024
jezdez
previously approved these changes
Jan 2, 2024
kenodegard
commented
Jan 2, 2024
kenodegard
force-pushed
the
samefile-regression
branch
from
8821ff9 to
6b0f82e
Compare
kenodegard
changed the title
conda_build.utils.samefile in favor of os.path.normpathconda_build.utils.samefile in favor of path to package mapping
jezdez
approved these changes
Jan 4, 2024
| assert set(precs_hardlinkB) == {precB} | ||
|
|
||
|
|
||
| @pytest.mark.benchmark |
There was a problem hiding this comment.
Noice!! This'll go well with codspeed.
2 tasks
2 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
which_packagerefactor #5041 switched from usingos.path.normcaseto compare paths to callingPath.samefilewhich callsos.stat. This became especially expensive for certain builds so we need torevertrevisit this change.The proposal here is to implement a cached mapping of files to packages making
which_packageintoO(n)for the first lookup andO(1)for all subsequent lookups.We add a benchmark/battery test to better compare implementations. Here are the results of running the benchmark test with a few different versions/ideas:
3.27.03.28.2normpathnormcaseResolves #5126
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?