Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch the more general ImportError if menuinst cannot be imported #5116

Merged
merged 2 commits into from
Dec 14, 2023
Merged

catch the more general ImportError if menuinst cannot be imported #5116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0de02e
catch the more general ImportError
jaimergp Dec 14, 2023
4ab7bf4
add news
jaimergp Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda_build/post.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1753,7 +1753,7 @@ def check_menuinst_json(files, prefix) -> None:
try:
import jsonschema
from menuinst.utils import data_path
except ModuleNotFoundError as exc:
except ImportError as exc:
log.warning(
"Found 'Menu/*.json' files but couldn't validate: %s",
", ".join(json_files),
Expand Down
19 changes: 19 additions & 0 deletions news/5116-menuinst-importerror
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* Catch the more general `ImportError` instead of `ModuleNotFoundError`, so we do handle the cases where `menuinst 1.x` is found. (#5116)

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
Loading