-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conda_index.index verbose DEBUG/INFO logging #5066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Nov 10, 2023
3 tasks
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
fix-conda_index-log-spam
branch
from
November 10, 2023 20:05
c503ac5
to
9f0ed50
Compare
Added a "closing" keyword to the OP for gh-4939. |
@kenodegard, @jezdez, since this is a fairly focused change, I'd like to add this to the |
@kenodegard, thanks for updating and re-running the tests. For posterity: One test failed on the first attempt:
|
kenodegard
approved these changes
Nov 17, 2023
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
[bot] added once the contributor has signed the CLA
locked
[bot] locked due to inactivity
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log messages from
conda_index.index
get put out with high verbosity.As an example, I built https://github.com/conda-forge/zlib-feedstock/tree/main
which yielded a build log with 936 lines -- 260 of those lines (about 28%) were
INFO
/DEBUG
messages fromconda_index.index
like these:closes: gh-4939
Checklist - did you ...
news
directory (using the template) for the next release's release notes?