Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize license disclaimer #4568

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Standardize license disclaimer #4568

merged 4 commits into from
Sep 21, 2022

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Aug 19, 2022

Description

Adding standardized license disclaimer and pragmas. See conda/conda#11183.

Copyright year picked based on the first commit timestamp.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard requested a review from a team August 19, 2022 16:17
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 19, 2022
dholth
dholth previously approved these changes Aug 19, 2022
Copy link
Contributor

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenodegard
Copy link
Contributor Author

pre-commit.ci autofix

@kenodegard
Copy link
Contributor Author

pre-commit.ci autofix

@kenodegard
Copy link
Contributor Author

Apparently, pyupgrade now strips out encoding pragmas, so removing that.

@kenodegard kenodegard changed the title Standardize disclaimer & pragma blurbs Standardize license disclaimer Aug 19, 2022
@kenodegard kenodegard added the in-progress issue is actively being worked on label Sep 14, 2022
@kenodegard kenodegard self-assigned this Sep 21, 2022
@kenodegard kenodegard merged commit e4d9b3b into conda:main Sep 21, 2022
@kenodegard kenodegard deleted the disclaimer branch September 21, 2022 21:14
@mbargull
Copy link
Member

Copyright year picked based on the first commit timestamp.

TBH, this doesn't make a lot of sense since conda-build started out as being part of conda itself, hence Copyright (c) 2012 Continuum Analytics, Inc. would be applicable for its very first code.
However, a lot of the code/source files are from 2016+, i.e., (c) 2012/(c) 2014 is not representative/true for that.

This should really be just

Copyright (c) Anaconda, Inc.
SPDX-License-Identifier: BSD-3-Clause

or even

SPDX-FileCopyrightText: Copyright (c) Anaconda, Inc.
SPDX-License-Identifier: BSD-3-Clause

to make all parts unambiguously parsable.

@mbargull
Copy link
Member

Well, to be sure if dropping the date is okay for U.S. copyright law, I looked it up (from https://www.copyright.gov/title17/):

Form of Notice.—If a notice appears on the copies, it shall consist of
the following three elements:
(1) the symbol © (the letter C in a circle), or the word “Copyright”, or the
abbreviation “Copr.”; and
(2) the year of first publication of the work; in the case of compilations or
derivative works incorporating previously published material, the year date of
first publication of the compilation or derivative work is sufficient. The year
date may be omitted where a pictorial, graphic, or sculptural work, with ac-
companying text matter, if any, is reproduced in or on greeting cards, postcards,
stationery, jewelry, dolls, toys, or any useful articles; and
(3) the name of the owner of copyright in the work, or an abbreviation by
which the name can be recognized, or a generally known alternative designa-
tion of the owner

So, probably best to retain the year...
I'd still rather go with 2012, though, i.e.,

SPDX-FileCopyrightText: Copyright (c) 2012 Anaconda, Inc.
SPDX-License-Identifier: BSD-3-Clause

then. It makes more sense to me and would also be more in line with the copyright notice from LICENSE.txt (that one still reads Continuum instead of Anaconda).

@dholth
Copy link
Contributor

dholth commented Dec 15, 2022 via email

@mbargull
Copy link
Member

Unicode © anyone

In theory, yes 😆.
I'm still worried about some random tool that manages to mess things up with non-ASCII source files -- stupid, ain't it!? Unicode 1.0 came about when I started to go to the "Kindergarten" ;).
(My brother's name has a non-ASCII character in it -- I'm still always a bit shocked when he dares to put it in his system user name...)

@kenodegard
Copy link
Contributor Author

@jezdez
Copy link
Member

jezdez commented Dec 16, 2022

Hey all, please do not argue about copyright topics below an already closed PR, this is far too delicate to do that. @mbargull Please file a ticket the next time.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Dec 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA in-progress issue is actively being worked on locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants