-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement negative matching for files
in outputs
#4197
Conversation
a223a5f
to
24579a7
Compare
@mingwandroid, I think this is ready for a review (sorry if there's a better @ ping for the conda-build team). The macOS jobs are failing, but the logs suggest it's not my fault.. |
Ping for anyone to review this. |
24579a7
to
8674ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to consider filenames starting with !
.
conda_build/build.py
Outdated
include = [f for f in files if not f.startswith('!')] | ||
exclude = [f[1:] for f in files if f.startswith('!')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to consider files which themselves start with a !
. For example with gitignore
you can start entries with \!
for this.
Personally, I'd rather suggest to have a more explicit form to avoid these custom syntax and special cases (also wrt. YAML tags). I.e., I'd rather have files
optionally be a dictionary with two keys:
files:
include:
- *.txt
exclude:
- do-not-want.txt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, @mbargull!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as keys in `files`
1aa2e2d
to
e56c573
Compare
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
This PR implements #4196 by adding supporting for a negative match expression for the
files
list inoutputs
.Closes #4196.