Added conjunction to comma_join, fixed islist #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaconda-issue-bot
added
the
cla-signed
Added ability to change the conjunction used by comma_join. Fixed islist bug which caused it to incorrectly treat classes with __iter__ as lists (e.g. islist(dict)).
|
It would appear that the failing test (macOS py37-release: test_api_build/test_env_creation_fail_exits_build) is unrelated to this change and fails erratically as seen in other pipelines. |
|
@mingwandroid - still no rush just didn't want to forget about these changes |
|
Hey @njalerikson, they've not been forgotten, as soon as I get back to conda-build, merging your changes will be my top priority. Thanks for the ping. |
jezdez
approved these changes
Jul 18, 2023
|
Blast from the past! |
jezdez
pushed a commit
that referenced
this pull request
Aug 17, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Conda Bot <[email protected]> Co-authored-by: Ken Odegard <[email protected]> Co-authored-by: Jannis Leidel <[email protected]> Co-authored-by: Bianca Henderson <[email protected]> Co-authored-by: conda-bot <[email protected]> fix islist (#4184)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to change the conjunction used by
comma_join(e.g.comma_join(iterable, conjunction="or"). Fixedislistbug which caused it to incorrectly treat classes with__iter__as lists (e.g.islist(dict)).Both of these changes are prompted by #4179, separated out here to make reviewing easier.