Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix get_or_merge_testing_config for cli tests #5076

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

mbargull
Copy link
Member

Description

cli.main_build.execute (et al.) call the function with **args.__dict__ with args having default values (e.g., croot=None) via parse_args.

Follow-up to gh-5068.
See #5066 (comment)

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 19, 2023
@mbargull mbargull marked this pull request as draft November 19, 2023 01:32
@mbargull mbargull force-pushed the ci-fixes-2023-11-part-2 branch from 427c0bc to af82bba Compare November 19, 2023 01:40
@mbargull
Copy link
Member Author

pre-commit.ci autofix

@mbargull mbargull force-pushed the ci-fixes-2023-11-part-2 branch from 8888af3 to 227f13f Compare November 19, 2023 01:44
cli.main_build.execute (et al.) call the function with **args.__dict__
with args having default values (e.g., croot=None) via parse_args.

Signed-off-by: Marcel Bargull <[email protected]>
@mbargull mbargull force-pushed the ci-fixes-2023-11-part-2 branch 2 times, most recently from a9a5c20 to 9d2c297 Compare November 19, 2023 23:54
@mbargull mbargull force-pushed the ci-fixes-2023-11-part-2 branch from 9d2c297 to 8f509ba Compare November 19, 2023 23:55
@mbargull
Copy link
Member Author

pre-commit.ci autofix

@mbargull
Copy link
Member Author

I took the opportunity to let this run multiple times (on Sunday so I don't cause large CI queues for others).
Overall, things look quite better than before but there are still some failures occasionally:

  1. macos (3.8, release, parallel)
FAILED tests/test_variants.py::test_build_run_exports_act_on_host - conda.exceptions.PackagesNotFoundError: The following packages are not available from current channels:

  - openssl
  - vc=9*

Current channels:

  - file:///Users/runner/work/_temp/parallel/popen-gw0/test_build_run_exports_act_on_0/win-32

To search for alternate channels that may provide the conda package you're
looking for, navigate to

    https://anaconda.org/

and use the search bar at the top of the page.
  1. linux (3.11, canary, serial)
FAILED tests/cli/test_main_build.py::test_build_add_channel - KeyError: PackageRecord(_hash=3447543960105723200, name='conda_build_test_requirement', version='1.0', build='h35b8010_0', build_number=0, channel=Channel("conda_build_test/linux-64"), subdir='linux-64', fn='conda_build_test_requirement-1.0-h35b8010_0.tar.bz2', md5='b643e7c94252b812aaff56ca1c83f002', url='https://conda.anaconda.org/conda_build_test/linux-64/conda_build_test_requirement-1.0-h35b8010_0.tar.bz2', arch='x86_64', platform='linux', depends=(), timestamp=1497374008.185, size=1978)
  1. linux (3.11, canary, parallel)
FAILED tests/cli/test_main_build.py::test_test_extra_dep - KeyError: PackageRecord(_hash=-5768541241801201921, name='test_test_extra_dep', version='1.0', build='1', build_number=1, channel=Channel("test_test_extra_dep0/linux-64"), subdir='linux-64', fn='test_test_extra_dep-1.0-1.tar.bz2', md5='2001052b4eac59e5e1c5808642dcf21a', url='file:///home/runner/work/_temp/parallel/popen-gw1/test_test_extra_dep0/linux-64/test_test_extra_dep-1.0-1.tar.bz2', sha256='22f404ef55a1a1c360402893d07cd136846a7012ee7fed0daad9fcf24524d89d', arch=None, platform=None, depends=(), license='contract in blood', timestamp=1700406669.469, size=3037)

Note:

  • All of these are sporadic failures and thus could be difficult to reproduce locally.
  • Ignore the serial/parallel test distinction for now; serial marked tests are actually run in parallel currently.
  • There could be interactions with conda-libmamba-solver, but (esp. for 2. and 3.) it is likely caused by package (index) cache corruptions (the tests re-use the same croot/pkgs-dirs and will occasionally trample on each other).

Re. 1: "Current channels" shows .../win-32 which is odd because the test uses platform="win", arch="64".
Re. 2: This is for the non-local https://anaconda.org/conda_build_test/conda_build_test_requirement/files .
Re. 3: This is for the local test_test_extra_dep which is in the correct Channel("test_test_extra_dep0/linux-64").

@mbargull mbargull marked this pull request as ready for review November 20, 2023 14:12
@mbargull
Copy link
Member Author

I've opened gh-5078 for the general notes on serial tests and collisions in the package cache.

@mbargull mbargull merged commit bc46f28 into conda:main Nov 20, 2023
24 checks passed
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants