Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disclaimer/LICENSE to reflect conda-build originally being part of conda #4676

Closed
wants to merge 3 commits into from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Dec 15, 2022

Description

We were reminded (#4568 (comment)) that conda-build's code was originally part of conda and only later (~2014) was it moved into a separate repo.

This change uses standard SPDX syntax for disclaimers (I opted to use ©, if there are any objections or concerns I'll switch it back to Copyright (c)), credits Continuum Analytics with the original copyright, and recognizes the rename to Anaconda in 2017.

Sought to otherwise standardize the disclaimer and LICENSE.txt to mirror that of conda (conda/conda#12183).

Ref https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard added source::anaconda created by members of Anaconda, Inc. in-progress issue is actively being worked on labels Dec 15, 2022
@kenodegard kenodegard self-assigned this Dec 15, 2022
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 15, 2022
Comment on lines +1 to +2
SPDX-FileCopyrightText: © 2012 Continuum Analytics, Inc. <http://continuum.io>
SPDX-FileCopyrightText: © 2017 Anaconda, Inc. <https://www.anaconda.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not overcomplicate things and go with

Suggested change
SPDX-FileCopyrightText: © 2012 Continuum Analytics, Inc. <http://continuum.io>
SPDX-FileCopyrightText: © 2017 Anaconda, Inc. <https://www.anaconda.com>
SPDX-FileCopyrightText: © 2012 Anaconda, Inc. <https://www.anaconda.com>

The copyright remained with the same entity (CIK: 0001538860), after all.
Let's just us the current name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SPDX-FileCopyrightText: © 2012 Continuum Analytics, Inc. <http://continuum.io>
SPDX-FileCopyrightText: © 2017 Anaconda, Inc. <https://www.anaconda.com>
SPDX-FileCopyrightText: © Anaconda, Inc. <https://www.anaconda.com>

@jezdez jezdez self-requested a review December 16, 2022 11:29
@jezdez
Copy link
Member

jezdez commented Jan 3, 2023

Hmm, I wonder if https://hynek.me/til/copyright-years/ might be worth another look, a lot of corporate project have removed the years altogether!

@mbargull
Copy link
Member

Hmm, I wonder if https://hynek.me/til/copyright-years/ might be worth another look, a lot of corporate project have removed the years altogether!

Ah, nice find! It's good to see that this is has some notable examples. That'd be my favored solution because it's more faithful, #4568 (comment) :

However, a lot of the code/source files are from 2016+, i.e., (c) 2012/(c) 2014 is not representative/true for that.

Going with SPDX-FileCopyrightText: © Anaconda, Inc. <https://www.anaconda.com> in the file headers and either leaving LICENSE.txt untouched or just substituting Continuum -> Anaconda sounds reasonable.
(Though, I'd leave 2012 in LICENSE.txt -- doesn't really hurt at that single place, plus it is a faithful statement in there.)

Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request has been open for a long time, just curious if we should close it.

@jezdez
Copy link
Member

jezdez commented Sep 26, 2023

No, this was blocked by the legal work being done in providing a trademark license to NumFOCUS and can now picked up again.

Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Sep 26, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Oct 26, 2024
@github-actions github-actions bot closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA in-progress issue is actively being worked on source::anaconda created by members of Anaconda, Inc. stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants