Add win-arm64 as a recognized platform (#4579)

* Add `win-arm64` as a recognized platform * Add news
conda · Sep 13, 2022 · 78a729e · 78a729e
1 parent 324ab82
commit 78a729e
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 2 deletions.
diff --git a/conda_build/cli/main_convert.py b/conda_build/cli/main_convert.py
@@ -63,7 +63,7 @@ def parse_args(args):
         choices=['osx-64', 'osx-arm64',
                  'linux-32', 'linux-64', 'linux-ppc64', 'linux-ppc64le',
                  'linux-s390x', 'linux-armv6l', 'linux-armv7l', 'linux-aarch64',
-                 'win-32', 'win-64', 'all'],
+                 'win-32', 'win-64', 'win-arm64', 'all'],
         help="Platform to convert the packages to.",
         default=None
     )

diff --git a/conda_build/convert.py b/conda_build/convert.py
@@ -767,7 +767,8 @@ def conda_convert(file_path, output_dir=".", show_imports=False, platforms=None,
         platforms = ['osx-64', 'osx-arm64',
                      'linux-32', 'linux-64', 'linux-ppc64', 'linux-ppc64le',
                      'linux-s390x', 'linux-armv6l', 'linux-armv7l', 'linux-aarch64',
-                     'win-32', 'win-64']
+                     'win-32', 'win-64', 'win-arm64',
+                     ]
 
     for platform in platforms:
 

diff --git a/conda_build/utils.py b/conda_build/utils.py
@@ -104,6 +104,7 @@ def glob(pathname, recursive=True):
     "linux-aarch64",
     "win-64",
     "win-32",
+    "win-arm64",
     "osx-64",
     "osx-arm64",
     "zos-z",

diff --git a/conda_build/windows.py b/conda_build/windows.py
@@ -85,6 +85,9 @@ def build_vcvarsall_vs_path(version):
 
 
 def msvc_env_cmd(bits, config, override=None):
+    # TODO: this function will likely break on `win-arm64`. However, unless
+    # there's clear user demand, it's not clear that we should invest the
+    # effort into updating a known deprecated function for a new platform.
     log = get_logger(__name__)
     log.warn("Using legacy MSVC compiler setup.  This will be removed in conda-build 4.0. "
              "If this recipe does not use a compiler, this message is safe to ignore.  "

diff --git a/news/4579-add-win-arm64 b/news/4579-add-win-arm64
@@ -0,0 +1,11 @@
+### Enhancements
+
+* Add `win-arm64` as a recognized platform (subdir).
+
+### Bug fixes
+
+### Deprecations
+
+### Docs
+
+### Other