Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic in 32-bit architecture check #168

Closed
wants to merge 7 commits into from
Closed

Fix logic in 32-bit architecture check #168

wants to merge 7 commits into from

Conversation

ktbarrett
Copy link
Contributor

Closes #166.

@goanpeca goanpeca requested review from bollwyvl and jaimergp April 2, 2021 10:54
@goanpeca
Copy link
Member

goanpeca commented Apr 2, 2021

Thanks for working on this @ktbarrett

Is there a way we can test this by updating some of the examples that run on CI ?

@ktbarrett
Copy link
Contributor Author

@goanpeca I'll look into adding some CI checks for other architectures. I see you have the checks oriented around the README examples, would you like some additional documentation added to the README?

@goanpeca
Copy link
Member

goanpeca commented Apr 2, 2021

Absolutely :)

We will move that to a docs site eventually

@goanpeca
Copy link
Member

goanpeca commented Apr 2, 2021

Also could you point this PR against the develop branch? And not the master one?

Thanks!

@chrisjbillington
Copy link
Contributor

Any chance of getting this merged soon?

@ktbarrett ktbarrett changed the base branch from master to develop April 11, 2021 21:44
@ktbarrett
Copy link
Contributor Author

Apparently I don't know anything.

@goanpeca
Copy link
Member

@ktbarrett thanks for working on this!

Apparently I don't know anything.

You need to compile the TS file into JS to be able to see any actual changes run on CI. See the the steps here:

https://github.com/conda-incubator/setup-miniconda/blob/master/CONTRIBUTING.md

@goanpeca
Copy link
Member

goanpeca commented Apr 12, 2021

@goanpeca
Copy link
Member

@ktbarrett since the 32bit installers are old, they might be using and old conda by default that does not provide the conda executable inside a condabin folder, but on a bin folder.

/usr/share/miniconda3/condabin/conda you will need to update the code accordingly where we define where to look for conda executables.

Thanks!

@goanpeca
Copy link
Member

@ktbarrett its turtles all the way down, now you see why adding support for this was on hold :)

So conda init is a command we rely on for correctly initializing conda, so in the 32 bit installer the conda that comes bundled does not provide that option, which means we wont be able to properly activate environments :-|

@goanpeca
Copy link
Member

Ideas @bollwyvl ?

@jaimergp
Copy link
Member

I think the first version to offer conda init and $CONDA_ROOT/condabin was 4.6.0. At least it looks like that from the release notes.

We can check which version is trying to get installed and error out if <4.6. Maybe there are other rough edges down there, but we can start with this.

cc @chrisjbillington @ktbarrett

@ktbarrett
Copy link
Contributor Author

closing in favor of #189.

@ktbarrett ktbarrett closed this Aug 13, 2021
@ktbarrett ktbarrett deleted the 32bit branch August 13, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still having errors with 32-bit miniconda setups
4 participants