-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic in 32-bit architecture check #168
Conversation
Thanks for working on this @ktbarrett Is there a way we can test this by updating some of the examples that run on CI ? |
@goanpeca I'll look into adding some CI checks for other architectures. I see you have the checks oriented around the README examples, would you like some additional documentation added to the README? |
Absolutely :) We will move that to a docs site eventually |
Also could you point this PR against the develop branch? And not the master one? Thanks! |
Any chance of getting this merged soon? |
Apparently I don't know anything. |
@ktbarrett thanks for working on this!
You need to compile the TS file into JS to be able to see any actual changes run on CI. See the the steps here: https://github.com/conda-incubator/setup-miniconda/blob/master/CONTRIBUTING.md |
there is. |
@ktbarrett since the 32bit installers are old, they might be using and old conda by default that does not provide the conda executable inside a
Thanks! |
@ktbarrett its turtles all the way down, now you see why adding support for this was on hold :) So |
Ideas @bollwyvl ? |
I think the first version to offer We can check which version is trying to get installed and error out if <4.6. Maybe there are other rough edges down there, but we can start with this. |
closing in favor of #189. |
Closes #166.