Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting deprecation warnings for "add-path" and "set-env" #78

Closed
uniqueg opened this issue Oct 6, 2020 · 1 comment · Fixed by #79
Closed

Getting deprecation warnings for "add-path" and "set-env" #78

uniqueg opened this issue Oct 6, 2020 · 1 comment · Fixed by #79

Comments

@uniqueg
Copy link

uniqueg commented Oct 6, 2020

Thanks for the nice project! Seems to work rather nicely - except that apart from warnings regarding duplicate channels that have already been reported (#57), I'm also getting rather worrying warnings from GitHub Actions regarding the use of add-path and set-env:

# Locating Miniconda...
#######################

/usr/share/miniconda

# Setup environment variables...
################################

Add "/usr/share/miniconda/condabin" to PATH
Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
/usr/share/miniconda/condabin/conda config --add pkgs_dirs /home/runner/conda_pkgs_dir
Warning: The `set-env` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

My workflow config:

on: [push, pull_request]

jobs:
  build:

    runs-on: ubuntu-latest
    defaults:
      run:
        shell: bash -l {0}
    strategy:
      matrix:
        python-version: [3.7, 3.8]

    steps:
    - uses: actions/checkout@v2
    - name: Setup Conda environment with Python ${{ matrix.python-version }}
      uses: conda-incubator/[email protected]
      with:
        activate-environment: install-deps
        auto-activate-base: false
        auto-update-conda: true
        environment-file: environment.yml
        python-version: ${{ matrix.python-version }}
  # ... 

Apparently this is related to a mild security vulnerability and the deprecation warnings have only been added a couple of days ago. See this blog post for more info, including how to mitigate the issue: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

@bollwyvl
Copy link
Contributor

bollwyvl commented Oct 6, 2020

Thanks! I think merging #77 (and cutting a release) will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants