-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda-store-ui 2024.10.1 + memory router #63
Conversation
This a draft PR because it depends on conda-incubator/conda-store-ui#429 getting merged and a new release of conda-store-ui getting cut. This PR will have to eventually update package.json with the new, fixed version of conda-store-ui. |
Now that conda-incubator/conda-store-ui#429 has been merged, we can go ahead with reviewing and merging this PR, so I'm taking it out of draft mode. |
Just tested this out locally. To be clear about installation, I'm running I'm getting 404 when I try to use this: |
@peytondmurray sorry about that! I took this PR out of draft mode without re-reading the PR description. In order to test the Jupyter frontend extension locally, you have to use an as-of-yet-not-released version of Conda Store UI that incorporates conda-incubator/conda-store-ui#429. But I thought we could get ahead of the next Conda Store UI release because this change is additive. It doesn't break anything, although I forgot about TypeScript. The TypeScript error should go away once the conda-store-ui dependency is bumped to include a future version that includes the memory router PR. I guess I should put this back in draft mode until the next release of Conda Store UI, then come back to this PR and update the UI version in package.json. Then it should be possible to follow the test instruction in the PR description and the TypeScript error should go away. |
Since we have now a 2024.10.1. release for conda-store-ui can this be taken out of Draft @gabalafou ? |
routerType
config var for future release of conda-store-ui
I updated the conda-store-ui version in this PR, so it should be possible to follow the manual testing instructions in the PR description. I went through them myself and everything worked. Once @peytondmurray does the same, I think this should be good to merge. |
I just tested locally, and everything worked as expected. I will leave it to @peytondmurray to review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so will go ahead and approve, thanks @gabalafou
CI failure is unrelated so will go ahead an merge (fix for CI is in #66 ) |
Companion to conda-incubator/conda-store-ui#429.
Pull request checklist
How to test
Load the extension locally and navigate. Make sure you can open an environment, click the edit button, click the cancel button, go to another environment, etc.