Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-store-ui 2024.10.1 + memory router #63

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

gabalafou
Copy link
Contributor

Companion to conda-incubator/conda-store-ui#429.

Pull request checklist

  • Did you test this change locally?
  • n/a Did you update the documentation (if required)?
  • n/a Did you add/update relevant tests for this change (if required)?

How to test

Load the extension locally and navigate. Make sure you can open an environment, click the edit button, click the cancel button, go to another environment, etc.

@gabalafou
Copy link
Contributor Author

This a draft PR because it depends on conda-incubator/conda-store-ui#429 getting merged and a new release of conda-store-ui getting cut.

This PR will have to eventually update package.json with the new, fixed version of conda-store-ui.

@gabalafou
Copy link
Contributor Author

Now that conda-incubator/conda-store-ui#429 has been merged, we can go ahead with reviewing and merging this PR, so I'm taking it out of draft mode.

@gabalafou gabalafou marked this pull request as ready for review October 18, 2024 12:17
@peytondmurray
Copy link

peytondmurray commented Oct 19, 2024

Just tested this out locally. To be clear about installation, I'm running docker compose up --build inside the latest commit of conda-store-ui (dc1a1988b5e6212c16439ef38cc0c9be92dc8740, which includes your routing fix) to bring up conda-store at localhost:8080/conda-store, which I see is the default for jupyterlab-conda-store. Is there anything else I need to do to authenticate or anything like that?

I'm getting 404 when I try to use this:

image
image

@gabalafou
Copy link
Contributor Author

gabalafou commented Oct 21, 2024

@peytondmurray sorry about that! I took this PR out of draft mode without re-reading the PR description.

In order to test the Jupyter frontend extension locally, you have to use an as-of-yet-not-released version of Conda Store UI that incorporates conda-incubator/conda-store-ui#429.

But I thought we could get ahead of the next Conda Store UI release because this change is additive. It doesn't break anything, although I forgot about TypeScript. The TypeScript error should go away once the conda-store-ui dependency is bumped to include a future version that includes the memory router PR.

I guess I should put this back in draft mode until the next release of Conda Store UI, then come back to this PR and update the UI version in package.json. Then it should be possible to follow the test instruction in the PR description and the TypeScript error should go away.

@trallard
Copy link
Collaborator

Since we have now a 2024.10.1. release for conda-store-ui can this be taken out of Draft @gabalafou ?

@trallard trallard added area: dependencies 📦 Issues related to conda-store dependencies block-release ⛔️ labels Oct 22, 2024
@trallard trallard marked this pull request as ready for review October 22, 2024 10:56
@gabalafou gabalafou changed the title Pass routerType config var for future release of conda-store-ui Bump conda-store-ui to v2024.10.1 and use new memory router Oct 22, 2024
@gabalafou gabalafou changed the title Bump conda-store-ui to v2024.10.1 and use new memory router conda-store-ui v2024.10.1 and memory router Oct 22, 2024
@gabalafou gabalafou changed the title conda-store-ui v2024.10.1 and memory router conda-store-ui 2024.10.1 and memory router Oct 22, 2024
@gabalafou gabalafou changed the title conda-store-ui 2024.10.1 and memory router conda-store-ui 2024.10.1 + memory router Oct 22, 2024
@gabalafou
Copy link
Contributor Author

I updated the conda-store-ui version in this PR, so it should be possible to follow the manual testing instructions in the PR description.

I went through them myself and everything worked.

Once @peytondmurray does the same, I think this should be good to merge.

@trallard
Copy link
Collaborator

I just tested locally, and everything worked as expected.
I only noticed that the version string went missing, but that is not a big deal.

I will leave it to @peytondmurray to review and merge.

JupyterLab

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so will go ahead and approve, thanks @gabalafou

@trallard
Copy link
Collaborator

CI failure is unrelated so will go ahead an merge (fix for CI is in #66 )

@trallard trallard merged commit e55b028 into main Oct 23, 2024
5 of 6 checks passed
@trallard trallard deleted the fix-conda-store-ui branch October 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 Issues related to conda-store dependencies block-release ⛔️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants