Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH - pre-release maintenance #21

Merged
merged 4 commits into from
Sep 18, 2023
Merged

ENH - pre-release maintenance #21

merged 4 commits into from
Sep 18, 2023

Conversation

trallard
Copy link
Collaborator

I am opening this PR to complete some maintenance tasks needed before the upcoming release of this package.

Description

This pull request:

  • Drops Python 3.7
  • Better metadata in the pyproject.toml

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

steff456
steff456 suggested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, I just left a minor comment.

I also tested it and it is building as expected,
image

pyproject.toml Show resolved Hide resolved
@trallard trallard marked this pull request as ready for review September 12, 2023 06:49
@trallard @steff456
Update python versions
4c65d03 
Co-authored-by: Stephannie Jimenez Gacha <[email protected]>
steff456
steff456 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trallard trallard merged commit 6f0a6fa into main Sep 18, 2023
@trallard trallard deleted the trallard/patch-1 branch September 18, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steff456 steff456 steff456 approved these changes

Assignees
No one assigned
Labels
status: in progress 🏗 type: maintenance 🛠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trallard @steff456