Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dependencies module into conda store server module #935

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Move dependencies module into conda store server module #935

merged 1 commit into from
Nov 1, 2024

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Oct 30, 2024 •
edited
Loading

Description

Only the fastapi app needs to define these depends pieces. Other pieces of the application should not be accessing this module.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@soapy1
Move dependencies module indo conda store server module
74c4bc4 
Only the fastapi app needs to define these depends pieces. Other
pieces of the application should not be accessing this module.
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 74c4bc4
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6722a666b3bf090008176743

@soapy1 soapy1 requested a review from peytondmurray October 30, 2024 21:35
@soapy1 soapy1 changed the title Move dependencies module indo conda store server module Move dependencies module into conda store server module Oct 31, 2024
peytondmurray
peytondmurray approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thanks!

@peytondmurray peytondmurray merged commit 463fc7c into conda-incubator:main Nov 1, 2024
27 checks passed
@soapy1 soapy1 deleted the move-dependiencies-modules branch November 1, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

Assignees
No one assigned
Labels
needs: review 👀 type: maintenance 🛠
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soapy1 @peytondmurray