Add conda config warning docs/message; add duration log for actions
#823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
peytondmurray
force-pushed
the
make-logs-user-friendly-810
branch
from
6bc4145 to
45b8455
Compare
peytondmurray
force-pushed
the
make-logs-user-friendly-810
branch
from
45b8455 to
b58bb6a
Compare
peytondmurray
added
area: documentation 📖
peytondmurray
force-pushed
the
make-logs-user-friendly-810
branch
2 times, most recently
from
40e5c7a to
ee1d14d
Compare
peytondmurray
force-pushed
the
make-logs-user-friendly-810
branch
from
c58eb4a to
437cc96
Compare
gabalafou
approved these changes
Jun 28, 2024
Comment on lines
+31
to
+34
| "Note that the output of `conda config --show` displayed below only reflects " | ||
| "settings in the conda configuration file, which might be overridden by " | ||
| "variables required to be set by conda-store via the environment. Overridden " | ||
| f"settings: CONDA_FLAGS={conda_flags}" |
There was a problem hiding this comment.
I'm getting three distinct messages from this paragraph:
conda configshows settings in Conda configuration file- Some of the settings shown may therefore not be accurate because they have been overridden by Conda Store.
- Here are some (all?) of the settings that have been overridden in Conda Store.
Is that accurate?
There was a problem hiding this comment.
Yes, these were the three things I was trying to convey. As far as I know these are all of the overridden settings as well.
kcpevey
reviewed
Jul 3, 2024
| that are actually used by conda-store. In particular, `conda-store` internally | ||
| sets `CONDA_FLAGS=--strict-channel-priority`, overriding the channel priority in | ||
| the conda configuration file. Please keep this in mind when using `conda config` | ||
| to inspect your conda configuration. |
There was a problem hiding this comment.
This is also (and perhaps more frequently) an issue when you view the logs for conda-store since the config is printed there as well. I think you've covered it in those logs already though.
kcpevey
reviewed
Jul 3, 2024
kcpevey
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
I just had a minor suggestion, otherwise, this looks great! Thanks @peytondmurray !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #810.
Description
This PR adds:
conda-storeto override user conda configuration, which should help clear up user uncertainty about the output ofconda config.Pull request checklist
main. The ones I expected to pass locally have passed.Notes
pytest conda_store_server/test/test_actions.py::test_action_decorator- that test specifically checks for the run time information output to stdout that this PR implements.