-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privatize internal conda-store API #820
Privatize internal conda-store API #820
Conversation
✅ Deploy Preview for conda-store canceled.
|
79e4366
to
5e45798
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peytondmurray, I am assuming that every function you left in the pubblic namespace either corresponds to a public rest api route or is used by the conda-store-ui, is that correct. I think this PR is great, I just want to double check that there aren't any little helper functions or anything that we could privatize. They wouldn't need to move to the _internal
namespace imo, just have prepend them with a _
. I am approving this based on the above assumption, but you might want to take another look through to see if any of the functions that are public could be privatized.
@peytondmurray Thanks for the PR.
Verified this, and looks good to me. :) From a design POV, would it make sense to actually move some configuration options (example configs, Nebari's conda-store config) out of |
100%, you're right. I'll move anything that contains subclasses of |
46cea0b
to
8fa29ff
Compare
8fa29ff
to
3f5c7da
Compare
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Closes #723.
Description
This PR privatizes most of conda-store and conda-store-server in preparation for implementing an upcoming backwards compatibility policy.
This pull request:
_internal
subpackages, except for a select few outward-facing APIs.Pull request checklist
Additional information
How to test
No special testing requirements because new behavior has not been introduced; standard CI tests are sufficient.