Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Add conda-store dependencies to pyproject.toml #798

Merged
merged 8 commits into from
Mar 26, 2024

Conversation

trallard
Copy link
Collaborator

Split from #792

Description

  • BumpJLab - now conda-store-ui is JLab >= 4.0 compatible
  • Update dev and runtime dependencies - server
  • Update runtime dependencies - core
  • Update dev dependencies - core

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

This can be tested by building the packages with hatch build both for conda-store and conda-store-server

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 9eb23ea
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6601dafd9d3a6f0008231d32

@trallard trallard marked this pull request as draft March 25, 2024 19:45
@trallard trallard marked this pull request as ready for review March 25, 2024 20:55
@trallard trallard requested a review from peytondmurray March 25, 2024 20:55
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the individual dependencies, but I like that more python deps are moving into pyproject.toml.

One thing that might be helpful for future maintainers would be a comment at the top of the environment.yaml files that are in various places in this repository with a brief note about what dependencies are okay to add to that file and which need to be added to pyproject.toml. Something like

This environment file is for <whatever purpose>; please put python project dependencies in pyproject.toml rather than here

or similar would be useful.

@trallard
Copy link
Collaborator Author

Thanks! Yes I plan to add such notes and docs as I wrap up the changes that were in that original PR.

@trallard trallard merged commit 1ee43a1 into main Mar 26, 2024
19 checks passed
@trallard trallard deleted the trallard/update-runtime-deps branch March 26, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants