-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT - Add conda-store dependencies to pyproject.toml #798
Conversation
✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the individual dependencies, but I like that more python deps are moving into pyproject.toml
.
One thing that might be helpful for future maintainers would be a comment at the top of the environment.yaml
files that are in various places in this repository with a brief note about what dependencies are okay to add to that file and which need to be added to pyproject.toml
. Something like
This environment file is for <whatever purpose>; please put python project dependencies in pyproject.toml rather than here
or similar would be useful.
Thanks! Yes I plan to add such notes and docs as I wrap up the changes that were in that original PR. |
Split from #792
Description
Pull request checklist
Additional information
How to test
This can be tested by building the packages with
hatch build
both forconda-store
andconda-store-server