Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update .pre-commit-config #796

Merged
merged 9 commits into from
Mar 26, 2024
Merged

🔧 Update .pre-commit-config #796

merged 9 commits into from
Mar 26, 2024

Conversation

trallard
Copy link
Collaborator

Split from #792

Description

  • 🔧 Update .pre-commit-config
  • 🔧 Update pre-commit config in pyproject.toml
  • Update docs and actions to use lint

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

  • Run pre-commit locally with pre-commit run all-files
  • Run with hatch with hatch env run -e lint lint

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for kaleidoscopic-dango-0cf31d ready!

Name Link
🔨 Latest commit b1d3302
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6601ccc54c3e1700085c43ee
😎 Deploy Preview https://deploy-preview-796--kaleidoscopic-dango-0cf31d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit a3ec591
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6603156a04aca60008cfe14f

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I especially like that pre-commit.ci will autoupdate. 🚀

Something weird is up with one of the tests, though it doesn't look like anything related. Is this flaky?

@trallard
Copy link
Collaborator Author

Seems like one of those network issues. I tried and re run the workflow multiple times with no avail and there is nothing in this PR that would affect tests.

Since it's a parallel test one will tag @nkaretnikov

Copy link
Contributor

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trallard That was a flaky test. Approving to unblock, but see the inline question about import sorting.

.pre-commit-config.yaml Show resolved Hide resolved
@trallard
Copy link
Collaborator Author

Thanks @nkaretnikov - those flaky tests are an absolute pain.

Reverted to vanilla isort btw

@trallard trallard merged commit b996728 into main Mar 26, 2024
19 of 21 checks passed
@trallard trallard deleted the trallard/update-pre-commit branch March 26, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants