-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Update .pre-commit-config #796
Conversation
✅ Deploy Preview for kaleidoscopic-dango-0cf31d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.
|
…-incubator/conda-store into trallard/update-pre-commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - I especially like that pre-commit.ci will autoupdate. 🚀
Something weird is up with one of the tests, though it doesn't look like anything related. Is this flaky?
Seems like one of those network issues. I tried and re run the workflow multiple times with no avail and there is nothing in this PR that would affect tests. Since it's a parallel test one will tag @nkaretnikov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trallard That was a flaky test. Approving to unblock, but see the inline question about import sorting.
Thanks @nkaretnikov - those flaky tests are an absolute pain. Reverted to vanilla |
Split from #792
Description
Pull request checklist
Additional information
How to test
pre-commit run all-files
hatch env run -e lint lint