Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Bump actions versions #795

Merged
merged 3 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build_docker_image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ permissions:
id-token: write # This is required for requesting the JWT
contents: read # This is required for actions/checkout

env:
FORCE_COLOR: "1" # Make tools pretty.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


jobs:
build_and_push_docker_image:
name: "Build Docker Images 🛠"
Expand All @@ -23,7 +26,7 @@ jobs:
uses: actions/checkout@v4

- name: "Retrieve secret from Vault 🗝"
uses: hashicorp/vault-action@v2
uses: hashicorp/vault-action@v3
with:
method: jwt
url: "https://quansight-vault-public-vault-b2379fa7.d415e30e.z1.hashicorp.cloud:8200"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ jobs:
- run: echo "Running on ${{ matrix.directory }}"

- name: "Check package build - ${{ matrix.directory }} 📦"
uses: hynek/build-and-inspect-python-package@v1
uses: hynek/build-and-inspect-python-package@main
with:
path: ${{ matrix.directory }}
upload-name-suffix: "-${{ matrix.directory }}"

# Adding a separate upload for publishing
- name: "Upload build artefacts 📤"
Expand Down
22 changes: 12 additions & 10 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@ name: Tests

env:
DEFAULT_PYTHON_VERSION: "3.10"
FORCE_COLOR: "1" # Make tools pretty.

on:
pull_request:
push:
branches:
- main


# ensuring only one instance is running at a given time
concurrency:
group: ${{ github.ref }}
Expand Down Expand Up @@ -43,7 +45,7 @@ jobs:
miniforge-version: latest

# This fixes a "DLL not found" issue importing ctypes from the hatch env
- name: Reinstall Python 3.10 on Windows runner
- name: "Reinstall Python 3.10 on Windows runner"
uses: nick-fields/[email protected]
with:
timeout_minutes: 9999
Expand Down Expand Up @@ -89,7 +91,7 @@ jobs:
uses: actions/checkout@v4

- name: "Set up env 🐍"
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
environment-file: conda-store-server/environment-dev.yaml
miniforge-version: latest
Expand All @@ -114,7 +116,7 @@ jobs:
pytest --video on ../tests/test_playwright.py

- name: "Upload test results 📤"
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ always() }}
with:
name: playwright-tests
Expand Down Expand Up @@ -142,13 +144,13 @@ jobs:
working-directory: conda-store
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
steps:
- name: "Checkout Repository 🛎"
uses: actions/checkout@v4

- name: "Set up Python 🐍"
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

Expand Down Expand Up @@ -209,20 +211,20 @@ jobs:
- conda-store
- conda-store-server
steps:
- name: "Checkout Repository"
- name: "Checkout Repository 🛎"
uses: actions/checkout@v4

- name: Set up Docker Buildx
- name: "Set up Docker Buildx"
uses: docker/setup-buildx-action@v3

- name: Lint Dockerfiles
- name: "Lint Dockerfiles 🔍"
uses: jbergstroem/hadolint-gh-action@v1
with:
dockerfile: ${{ matrix.docker-image }}/Dockerfile
output_format: tty
error_level: 0

- name: Docker Meta
- name: "Docker Meta"
id: meta
uses: docker/metadata-action@v5
with:
Expand All @@ -231,7 +233,7 @@ jobs:
tags: |
type=sha

- name: Build docker
- name: "Build Docker images"
uses: docker/build-push-action@v5
with:
context: "${{ matrix.docker-image }}"
Expand Down
Loading