New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conda recipe with verification workflow #793

Merged

trallard merged 16 commits into main from add-recipe

Apr 2, 2024

Member

jaimergp commented Mar 23, 2024 •

edited

Loading

(Part of a conversation with @trallard)

Description

This pull request:

Adds recipe/ with a couple minor fixes (to be contributed to conda-forge)
Adds a Release workflow step depending on a new action https://github.com/jaimergp/conda-build-action
Together this all ensures the conda dependencies are in sync with the Python ones

Pull request checklist

Did you test this change locally?
Did you update the documentation (if required)?
Did you add/update relevant tests for this change (if required)?

Additional information

How to test

This is a CI change, so it's a matter of making the CI pass. That said, one can run conda build recipe in different OSs to get a feeling.

jaimergp added 2 commits

March 23, 2024 16:00


          Add and fix recipe

e9d6839


          Check conda builds

9de9ea9

netlify bot commented Mar 23, 2024 •

edited

Loading

✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name	Link
🔨 Latest commit	`7b99a2c`
🔍 Latest deploy log	https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/66031668e4d42b0008c2fba4

jaimergp and others added 9 commits

March 23, 2024 16:04


          only one workflow is enough

c189b59


          build from ../

064bf0c


          fix recipe (add hatchling and conda-lock!)

8a15191


          [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci


          Use a separate workflow

ba0d459


          retrigger

6bb66c1


          retrigger

04253c9


          let things run

09c5600


          add artifact name

177499a

jaimergp marked this pull request as ready for review

March 25, 2024 08:58

jaimergp commented

View reviewed changes

.github/workflows/release.yaml Outdated Show resolved Hide resolved


          Apply suggestions from code review

de7973e

jaimergp commented

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

jaimergp commented

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

jaimergp commented

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

jaimergp commented

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

jaimergp commented

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

jaimergp commented

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved


          Merge branch 'main' into add-recipe

3540dfe

trallard reviewed

View reviewed changes

Collaborator

trallard left a comment

Added a number of changes ad other missing deps

.github/workflows/conda.yml Show resolved Hide resolved

recipe/meta.yaml Outdated Show resolved Hide resolved

recipe/meta.yaml Outdated Show resolved Hide resolved

recipe/meta.yaml Show resolved Hide resolved

trallard added type: enhancement 💅🏼 area: dependencies 📦 status: needs changes 🧱 area: CI 👷🏽‍♀️ labels


          Apply suggestions from code review

40f8d9a

Co-authored-by: Tania Allard <[email protected]>

jaimergp commented

View reviewed changes

.github/workflows/conda.yml Show resolved Hide resolved


          Update recipe/meta.yaml

7e1f5e7

Co-authored-by: jaimergp <[email protected]>


          Apply suggestions from code review

7b99a2c

Co-authored-by: jaimergp <[email protected]>

trallard approved these changes

View reviewed changes

Collaborator

trallard left a comment

This looks good. If CI is happy 😬 we can merge

trallard added status: merge ready 🚀 and removed status: needs changes 🧱 labels

trallard merged commit 8088f74 into main

23 of 25 checks passed

trallard deleted the add-recipe branch

April 2, 2024 10:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: CI 👷🏽‍♀️ area: dependencies 📦 status: merge ready 🚀 type: enhancement 💅🏼