Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conda_flags configurable #790

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

patrix58
Copy link
Contributor

Currently the conda_flags parameter in https://github.com/conda-incubator/conda-store/blob/2024.3.1/conda-store-server/conda_store_server/action/generate_lockfile.py#L20 but this is not configurable.

This PR includes changes to have the conda_flags parameter configurable from the config py script.

Description

We are using conda-store within nebari in one of our projects. We have a reason why we don't need strict channel priority while building the environments. The default is still --strict-channel-priority to be backwards compatible, but it makes the option to the user to configure different conda flags e.g. --no-channel-priority.

Pull request checklist

  • running tests locally
  • was deployed and tested with nebari on a k8s cloud

How to test

Add e.g. c.CondaStore.conda_flags = "--no-channel-priority" in the config py script.

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit f657ad8
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6620b8d654c9a700082a8ddc

@nkaretnikov nkaretnikov force-pushed the customizable-conda-flags branch from 95593e7 to f657ad8 Compare April 18, 2024 06:08
Copy link
Contributor

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrix58 Thanks, LGTM!

@nkaretnikov nkaretnikov merged commit 3c4547b into conda-incubator:main Apr 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants