-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CONDA_STORE_DIR
to platformdirs.user_data_path
#786
Set CONDA_STORE_DIR
to platformdirs.user_data_path
#786
Conversation
✅ Deploy Preview for conda-store canceled.
|
2bb63ef
to
e84577a
Compare
CONDA_STORE_DIR
to platformdirs.user_data_dir
CONDA_STORE_DIR
to platformdirs.user_data_path
@jaimergp This is ready and tested, PTAL. CI failures are unrelated. |
docusaurus-docs/conda-store/references/configuration-options.md
Outdated
Show resolved
Hide resolved
docusaurus-docs/conda-store/references/configuration-options.md
Outdated
Show resolved
Hide resolved
docusaurus-docs/conda-store/references/configuration-options.md
Outdated
Show resolved
Hide resolved
docusaurus-docs/conda-store/references/configuration-options.md
Outdated
Show resolved
Hide resolved
This looks good. Let's discuss the pinning item briefly and then we can make a decision. |
@jaimergp Updated, PTAL. The only concern I have is that the library version bounds might not be strict enough. The authors introduced a breaking change between 2.5.4 and 2.6.0. But this can also be updated later if we run into problems. |
Yea, I saw that, but hopefully they have learnt from that oversight. Also this kind of comment makes me believe they are being more careful now and not too keen on breaking anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more thing.
Also, since this adds a new dependency, what's the process for letting the release manager know there are new deps to be added to the conda recipe? Will they look at a specific file? Maybe pyproject.toml also needs adjusting?
Only the |
1053f56
to
1757546
Compare
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
1757546
to
03059d7
Compare
Fixes #648.
Description
This pull request:
CONDA_STORE_DIR
toplatformdirs.user_data_path
Pull request checklist
Additional information
How to test