Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user journey for logging in and deleting shared environment #776

Merged

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Mar 8, 2024

Fixed #669.

Description

This PR implements an integration test which checks that an admin can create an environment in a shared namespace and delete both the environment and the namespace.

This pull request:

  • Adds an integration test which logs a user in and deletes an environment in a shared namespace and the namespace itself
  • Modifies the existing test_admin_user_can_create_environment test; previously, that test was doing something very similar to what the new test implemented in this PR does. With this change, the existing test now tests that an admin can create an environment in the default namespace, more closely matching the existing docstring.
  • This PR refactors the user_journeys.utils.API class to wait for responses from the conda-store server so that we don't need to do response handling in every test we write.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

  1. Load the conda-store server with docker compose up
  2. Run the test with pytest conda-store-server/tests/user_journeys/test_user_journeys.py

Alternatively, these tests are run as part of CI.

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 33aa67a
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65eb9f0e12e90200087cc268

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit c7a789c
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65f481dc3c09b70008c01581

Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@peytondmurray peytondmurray force-pushed the test-login-delete-env-669 branch from 7a4fa9b to b15a4e1 Compare March 15, 2024 17:13
@peytondmurray peytondmurray merged commit fe6b45a into conda-incubator:main Mar 15, 2024
19 checks passed
@peytondmurray peytondmurray deleted the test-login-delete-env-669 branch March 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Integration Test: Login and delete shared environment
2 participants