-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to create environment from lockfile #772
Merged
nkaretnikov
merged 32 commits into
conda-incubator:main
from
nkaretnikov:lockfile-envs-676
May 1, 2024
Merged
Add ability to create environment from lockfile #772
nkaretnikov
merged 32 commits into
conda-incubator:main
from
nkaretnikov:lockfile-envs-676
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-store canceled.
|
nkaretnikov
added
type: enhancement 💅🏼
area: api 🌐
status: in progress 🏗
project: JATIC
Work item needed for the JATIC project
area: user experience 👩🏻💻
Items impacting the end-user experience
labels
Mar 3, 2024
nkaretnikov
commented
Mar 3, 2024
nkaretnikov
commented
Mar 3, 2024
nkaretnikov
commented
Mar 3, 2024
nkaretnikov
commented
Mar 3, 2024
nkaretnikov
commented
Mar 4, 2024
nkaretnikov
force-pushed
the
lockfile-envs-676
branch
2 times, most recently
from
March 4, 2024 07:56
5caa45a
to
3cebcb4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nkaretnikov
added
needs: review 👀
status: in progress 🏗
and removed
status: in progress 🏗
labels
Mar 8, 2024
@jaimergp A gentle reminder that this needs review. |
jaimergp
requested changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this live, but I already have a few comments about the initial implementation. See inlines for more details, but to sum up:
- Use dropdown menu instead of a checkbox
- Don't push data model abstractions to the UI (the user should not need to manipulate their lockfile when copy-pasting). Instead, add extra fields as needed.
- constructor does support
explicit.txt
lockfiles which can be easily generated from the conda-lock.yml.
conda-store-server/conda_store_server/action/generate_constructor_installer.py
Outdated
Show resolved
Hide resolved
conda-store-server/conda_store_server/action/generate_constructor_installer.py
Outdated
Show resolved
Hide resolved
conda-store-server/conda_store_server/server/templates/create.html
Outdated
Show resolved
Hide resolved
conda-store-server/conda_store_server/server/templates/create.html
Outdated
Show resolved
Hide resolved
conda-store-server/conda_store_server/server/templates/create.html
Outdated
Show resolved
Hide resolved
nkaretnikov
force-pushed
the
lockfile-envs-676
branch
from
April 8, 2024 00:30
48d0720
to
06a9403
Compare
nkaretnikov
force-pushed
the
lockfile-envs-676
branch
from
May 1, 2024 02:51
c9bbf34
to
6bb3ae8
Compare
peytondmurray
pushed a commit
to peytondmurray/conda-store
that referenced
this pull request
May 4, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: api 🌐
area: user experience 👩🏻💻
Items impacting the end-user experience
project: JATIC
Work item needed for the JATIC project
type: enhancement 💅🏼
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #676.
Description
This pull request:
Pull request checklist
Additional information
How to test
Automated testing
Manual testing
Do not forget to click on the checkbox
The keys are:
name
,description
, andlockfile
. conda-store requires that a specification has a name, which is why this wraps an upstream conda-lock lockfile format instead of passing it directly as a specification. Fromconda-store-server/conda_store_server/schema.py
:lockfile
corresponds to a lockfile that conda-store produces, which is the v1 conda-lock lockfile: