Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add JupyterLab Extension docs page #752

Merged
merged 10 commits into from
Mar 14, 2024
Merged

[DOC] Add JupyterLab Extension docs page #752

merged 10 commits into from
Mar 14, 2024

Conversation

pavithraes
Copy link
Member

Addresses #561

Description

This pull request:

  • Creates a landing page for JLab extension with installation instructions.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)? N/A

Additional information

How to test

@pavithraes pavithraes self-assigned this Jan 30, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024 •
edited
Loading

✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 5a59170
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65f086b49efa8b0008a05c57

@pavithraes pavithraes added area: documentation 📖 Improvements or additions to documentation status: in progress 🏗 labels Jan 30, 2024
@pavithraes pavithraes mentioned this pull request Jan 30, 2024
Closed
@pavithraes pavithraes changed the title [DOC] Add JupyterLab Extension docs [DOC] Add JupyterLab Extension docs page Feb 6, 2024
@pavithraes pavithraes marked this pull request as ready for review February 6, 2024 14:59
@trallard trallard requested a review from gabalafou February 6, 2024 17:03
gabalafou
gabalafou requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice! I added a few comments, I think at least a couple of them will need to be addressed

docusaurus-docs/jupyterlab-conda-store/introduction.md Outdated Show resolved Hide resolved
docusaurus-docs/jupyterlab-conda-store/introduction.md Outdated Show resolved Hide resolved
docusaurus-docs/jupyterlab-conda-store/introduction.md Outdated Show resolved Hide resolved
docusaurus-docs/jupyterlab-conda-store/introduction.md Outdated Show resolved Hide resolved
docusaurus-docs/jupyterlab-conda-store/introduction.md Outdated Show resolved Hide resolved
docusaurus-docs/jupyterlab-conda-store/introduction.md Outdated Show resolved Hide resolved
docusaurus-docs/jupyterlab-conda-store/introduction.md Outdated Show resolved Hide resolved
docusaurus-docs/jupyterlab-conda-store/introduction.md Show resolved Hide resolved
docusaurus-docs/docusaurus.config.js Show resolved Hide resolved
@pavithraes
Copy link
Member Author

@gabalafou - Thanks for a thorough review, I've addressed all your comments. :)

@pavithraes pavithraes merged commit d345670 into conda-incubator:main Mar 14, 2024
19 checks passed
@pavithraes pavithraes deleted the jlab-ext branch September 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabalafou gabalafou gabalafou approved these changes

Assignees

@pavithraes pavithraes

Labels
area: documentation 📖 Improvements or additions to documentation needs: review 👀
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavithraes @gabalafou