Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string substitution in normalized_channel_url #710

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

nkaretnikov
Copy link
Contributor

@nkaretnikov nkaretnikov commented Dec 17, 2023

Fixes #602.

Description

This pull request: appends the trailing slash to normalized_channel_url via string interpolation. The previous method of using the / operator was ignoring the trailing slash on Windows, which caused a channel_replacements lookup failure.

On Linux:

In [2]: yarl.URL("foo") / "./"
Out[2]: URL('foo/')

On Windows the slash is not appended, so the lookup in channel_replacements failed:

In [4]: yarl.URL("foo") / "./"
Out[4]: URL('foo')

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit b7a81f0
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6580a2366f9194000821255f

@nkaretnikov nkaretnikov added status: in progress 🏗 area: dependencies 📦 Issues related to conda-store dependencies area: user experience 👩🏻‍💻 Items impacting the end-user experience labels Dec 17, 2023
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nkaretnikov - all seems to be in order and tests are passing so will approve and merge

@trallard trallard merged commit 703b001 into conda-incubator:main Dec 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 Issues related to conda-store dependencies area: user experience 👩🏻‍💻 Items impacting the end-user experience
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

conda-store-worker not downloading repodata for main channel
2 participants