-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable code that depends on conda-docker #667
Disable code that depends on conda-docker #667
Conversation
✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.
|
53b26fe
to
65fc72e
Compare
e524bb5
to
bf69e05
Compare
test_generate_conda_docker
action_generate_conda_docker
on all platforms
action_generate_conda_docker
on all platforms
The conda-store docker bits are not well maintained at this moment. I would be fine with merging this but would like us to have a plan for if in the future we would like to support this. This feature is powerful since it allows conda-store to build docker images of environments without docker/root but I would say was largely an experiment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a warning saying "Temporarily disabled; see XXX" and return early instead of commenting things out? Thanks!
@costrouc I'm planning to fix the upstream issue in conda-docker ASAP. There are some suggestions from Jaime to try, but I cannot say anything concrete since I haven't tried anything yet. @jaimergp Updated. I've used the same message everywhere that we have elsewhere instead of the "Temporary" one. I also don't like the word "temporary" since it's somewhat meaningless (everything is temporary to some extent). I think the other message conveys the intention to support this feature in the future as well. Using the same message in the warning and error will also make it easier to discover both once people search for one of them. I also use a full URL instead of an issue number to make it easier to understand which repo this refers to. |
See #666.