-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shorter build_key
#652
Merged
nkaretnikov
merged 12 commits into
conda-incubator:main
from
nkaretnikov:shorter-build-key-611
Nov 28, 2023
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4c0082d
Use shorter `build_key`
fe2e9c7
Truncate only the hash, add a constant
542d911
Fix syntax warnings
9b9bb65
Allow to set `build_key_version` via the config
8f155ec
Update migration
998512f
Add `BuildKey` class
nkaretnikov 24be46a
Use the same "local import" comment
nkaretnikov 9013d1a
Add missing type hints to `BuildKey`
nkaretnikov 0ae713b
Document build key versions
nkaretnikov b44be1b
Mention `build_key_version` in `CondaStore` options
nkaretnikov aa4598d
Explain how hash is computed from `CondaSpecification`
nkaretnikov 36da8f0
Add a docstring to `BuildKey`
nkaretnikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "environment specification" you mean the input package requests, or the solved environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Added this:
(
CondaSpecification
, which represents a user-provided environment, isconverted to a dict and passed to
datastructure_hash
, which recursively sortsit and calculates the SHA-256 hash)