Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change url_prefix to /conda-store #647

Closed

Conversation

nkaretnikov
Copy link
Contributor

This is what conda-store-ui expects, which allows running conda-store-server in standalone mode without passing the config.

Fixes #646.

This is what conda-store-ui expects, which allows running
conda-store-server in standalone mode without passing the config.

Fixes conda-incubator#646.
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 82e6805
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/653ff9557a9d930008bacdc8

@nkaretnikov
Copy link
Contributor Author

nkaretnikov commented Oct 30, 2023

With this PR, it's now possible to just do python -m conda_store_server.server --standalone and use the Login button on the homepage, which is served by conda-store-ui. Tested on Windows and Linux. See the issue for details and this comment conda-incubator/conda-store-ui#322 (comment).

Note: this branch is based on main, but I removed the port change commit, which prevents this from working by default, see conda-incubator/conda-store-ui#322. When this PR lands, the port issue still won't be solved, so this won't work by default. But on this particular branch everything works fine.

@costrouc
Copy link
Member

costrouc commented Nov 7, 2023

@nkaretnikov I'm surprised this is needed. For the typical install I would expect url_prefix to be /. The only reason /conda-store is used is since this is required for deployments with multiple services under the same domain. We can meet to talk about this if you'd like?

@nkaretnikov
Copy link
Contributor Author

Discussed this offline. A better solution would be to do this on the UI side. The /conda-store prefix exists mostly for running within Nebari.

@nkaretnikov nkaretnikov closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Change defaults so that standalone runs with the UI without the config
2 participants