Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Update pre-commit hooks #577

Merged
merged 6 commits into from
Sep 15, 2023
Merged

MAINT - Update pre-commit hooks #577

merged 6 commits into from
Sep 15, 2023

Conversation

trallard
Copy link
Collaborator

  • 📝 Add versioning changes
  • 🔧 Update pre-commits
  • 🚨 Lint files

Description

This pull request:

  • Adds a note on the change to CalVer (sorry was planning to do a pre-release)
  • Update pre-commits and lints files

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 7921a3b
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6504a0a83eb8380008bc6cab

@trallard trallard changed the title MAINT - Update pre-commits MAINT - Update pre-commit hooks Sep 15, 2023
Copy link
Contributor

@kcpevey kcpevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the svgs showing up as deleted and re-added? Seems like we can avoid that added weight to the repo. Unless these are "real" changes that I can't see.

  • docusaurus-docs/static/img/logo.svg.
  • docs/_static/images/conda-store-logo-vertical-lockup.svg
  • docs/_static/images/conda-store-logo-symbol.svg

Same for docs/_static/openapi.json and docs/diagrams_sources/conda-store-database-architecture.drawio - they seem to be identical (with a quick glance).

Aside from that, I just had one grammar thing and everything else looked fine from a look through standpoint. Just need to investigate those failing tests.

SECURITY.md Outdated Show resolved Hide resolved
@kcpevey kcpevey merged commit 432eaa1 into main Sep 15, 2023
@trallard trallard deleted the trallard/main-pre-commits branch September 20, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants